로고, 버튼, 아이콘버튼 마이그레이션, ThemeProvider 스토리북에 적용 #54
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hustle-dev
reviewed
Mar 21, 2022
| export const LogoIcon = () => { | ||
| return ( | ||
| <svg width="1.4em" height="1.4em" viewBox="0 0 52 52" fill="none" xmlns="http://www.w3.org/2000/svg"> | ||
| <circle cx="26" cy="26" r="26" fill="#529715" /> |
Contributor
There was a problem hiding this comment.
title 속성을 넣어서 접근성을 챙기는 것은 어떨까요?
hanana1253
reviewed
Mar 21, 2022
| width: 130px; | ||
| transition: 400ms width ease; | ||
|
|
||
| ${media.mobile} { |
Member
There was a problem hiding this comment.
오오 utils에서 import 하는 media 이건 어디에서 배운 신기한 것인가요?
Contributor
Author
There was a problem hiding this comment.
구글링하다가 이렇게 분리하면 좋을 것 같아서 적용해보았습니다~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
Related Issues
#26 #29 #51 #52
What does this PR do?
Other information